[
https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320416#comment-14320416
]
Tong Li commented on KAFKA-1926:
--------------------------------
[~jkreps] Removal of Time.scala cause a lot of code changes. Since Time.scala
defined the SystemTime object and get used all over the place. Though another
class SystemTime defined in client util package as a java class. The use of the
SystemTime object in the core is like using the property, not method calls, I
can rework that part, but it will be a lot of code like this
SystemTime.milliseconds
To be changed to:
new SystemTime().milliseconds()
Since the code in client common util gets defined as a regular class. I feel
doing that also will cost quite a bit rather than stick with the scala
SystemTime and simply calls its property, not many instance gets created. Let
me know what you think and we can always improve.
Thanks.
> Replace kafka.utils.Utils with o.a.k.common.utils.Utils
> -------------------------------------------------------
>
> Key: KAFKA-1926
> URL: https://issues.apache.org/jira/browse/KAFKA-1926
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.2.0
> Reporter: Jay Kreps
> Labels: newbie, patch
> Attachments: KAFKA-1926.patch, KAFKA-1926.patch
>
>
> There is currently a lot of duplication between the Utils class in common and
> the one in core.
> Our plan has been to deprecate duplicate code in the server and replace it
> with the new common code.
> As such we should evaluate each method in the scala Utils and do one of the
> following:
> 1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose
> utility in active use that is not Kafka-specific. If we migrate it we should
> really think about the API and make sure there is some test coverage. A few
> things in there are kind of funky and we shouldn't just blindly copy them
> over.
> 2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold
> any utilities that really need to make use of Scala features to be convenient.
> 3. Delete it if it is not used, or has a bad api.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
