> On Feb. 10, 2015, 8:12 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/errors/NotEnoughReplicasAfterAppendException.java, > > line 24 > > <https://reviews.apache.org/r/29647/diff/2/?file=821997#file821997line24> > > > > Can you clarify why this should no longer be retriable?
This error occures when the message was appended to the log and on subsequent attempt to replicate, the ISR was too small to support min.isr requirement. A retry in this case will generate duplicates since the message was written on lead replica. Note that this should be quite rare - we check min.isr before appending to leader, but there's always the possibility of ISR shrinking after the append was already done and before replication completed. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/#review71842 ----------------------------------------------------------- On Jan. 14, 2015, 11:41 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29647/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 11:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1697 > https://issues.apache.org/jira/browse/KAFKA-1697 > > > Repository: kafka > > > Description > ------- > > trivial change to add byte serializer to ProducerPerformance; patched by Jun > Rao > > > KAFKA-1723 (delta patch to fix javadoc); make the metrics name in new > producer more standard; patched by Manikumar Reddy; reviewed by Jun Rao > > > removed broker code for handling acks>1 and made > NotEnoughReplicasAfterAppendException non-retriable > > > added early handling of invalid number of acks to handler and a test > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/errors/InvalidRequiredAcksException.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/errors/NotEnoughReplicasAfterAppendException.java > 75c80a97e43089cb3f924a38f86d67b5a8dd2b89 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 3316b6a1098311b8603a4a5893bf57b75d2e43cb > core/src/main/scala/kafka/cluster/Partition.scala > b230e9a1fb1a3161f4c9d164e4890a16eceb2ad4 > core/src/main/scala/kafka/server/KafkaApis.scala > c011a1b79bd6c4e832fe7d097daacb0d647d1cd4 > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala > cd16ced5465d098be7a60498326b2a98c248f343 > core/src/test/scala/unit/kafka/api/testKafkaApis.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/29647/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
