----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30845/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/browse/KAFKA-1926 Repository: kafka Description ------- This is the first patch set to address issue KAFKA-1926 Following things happen in this patch set: 1. Crc32.java was removed so that the core uses the same class defined in the client package. 2. Removed Time trait defined in Time.scala to use the interface defined in the client Time module. 3. Rewrite the SystemTime object in Time.scala so that it uses the client SystemTime class. 4. References to Time has been all refacted to use the interface defined in client module. Diffs ----- core/src/main/scala/kafka/cluster/Partition.scala 419d336824641e5a4100157dceeba5a59dcb33af core/src/main/scala/kafka/cluster/Replica.scala bd13c20338ce3d73113224440e858a12814e5adb core/src/main/scala/kafka/log/Log.scala ec192155bec7b643025f8044b0b6565c7b9977d1 core/src/main/scala/kafka/log/LogCleaner.scala f8e7cd5fabce78c248a9027c4bb374a792508675 core/src/main/scala/kafka/log/LogManager.scala 95ca8dbb9ea8b199c204df89b3a63f9d67e0f21d core/src/main/scala/kafka/log/LogSegment.scala ac9643423a28d189133705ba69b16cfce23f0049 core/src/main/scala/kafka/network/SocketServer.scala 39b1651b680b2995cedfde95d74c086d9c6219ef core/src/main/scala/kafka/server/KafkaServer.scala 1691ad7fc80ca0b112f68e3ea0cbab265c75b26b core/src/main/scala/kafka/server/ReplicaManager.scala 1afb0cbc403ad6f0bbaba5a35940d031e71fd3cf core/src/main/scala/kafka/server/TopicConfigManager.scala 47295d40131492aaac786273819b7bc6e22e5486 core/src/main/scala/kafka/utils/Crc32.java af9fe0d7d4ab215190c2fe4d1d165a8ffea4cdc2 core/src/main/scala/kafka/utils/Throttler.scala d1a144d7882919426824799ff8e8a47f89c83158 core/src/main/scala/kafka/utils/Time.scala 194cc1fa73b6a68914caf46b7dd7d415b2ff6a9f core/src/main/scala/kafka/utils/Utils.scala 23aefb4715b177feae1d2f83e8b910653ea10c5f core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala cd302aa51eb8377d88b752d48274e403926439f2 core/src/test/scala/unit/kafka/server/LogOffsetTest.scala c06ee756bf0fe07e5d3c92823a476c960b37afd6 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 09ed8f5a7a414ae139803bf82d336c2d80bf4ac5 core/src/test/scala/unit/kafka/utils/MockScheduler.scala d5896ed4d3b73aecb652436b5dfc80c2835af595 core/src/test/scala/unit/kafka/utils/MockTime.scala ee65748afefd5e2d699e68fbd402b0ed9a659589 core/src/test/scala/unit/kafka/utils/TestUtils.scala c9e8ba257b77f46c5c9b62b451470348b6e58889 Diff: https://reviews.apache.org/r/30845/diff/ Testing ------- Thanks, Tong Li