> On Feb. 7, 2015, 3:33 p.m., Neha Narkhede wrote: > > Thanks for attaching the latest run of the tool. I observed that we should > > get rid of zookeeper error message from > > Could not fetch offset from zookeeper for group g1 partition [t1,0] due to > > org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = > > NoNode for /consumers/g1/offsets/t1/0. > > > > It is somewhat unreadable and not very useful for the user. The best way to > > handle this in a user facing tool is to explain the cause, rather than use > > the error message directly. > > > > Other than that, the patch looks good. Once you fix the above problem, I > > will check it in.
Updated the rb with a hopefully more readable output and attached another sample run. I take it that the known issue regarding deleted topics and describing groups I mentioned earlier should get addressed in a later patch? - Onur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/#review71555 ----------------------------------------------------------- On Feb. 9, 2015, 10:37 p.m., Onur Karaman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29831/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 10:37 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1476 > https://issues.apache.org/jira/browse/KAFKA-1476 > > > Repository: kafka > > > Description > ------- > > Merged in work for KAFKA-1476 and sub-task KAFKA-1826 > > > Diffs > ----- > > bin/kafka-consumer-groups.sh PRE-CREATION > core/src/main/scala/kafka/admin/AdminUtils.scala > 28b12c7b89a56c113b665fbde1b95f873f8624a3 > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > core/src/test/scala/unit/kafka/admin/DeleteConsumerGroupTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 33c27678bf8ae8feebcbcdaa4b90a1963157b4a5 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 54755e8dd3f23ced313067566cd4ea867f8a496e > > Diff: https://reviews.apache.org/r/29831/diff/ > > > Testing > ------- > > > Thanks, > > Onur Karaman > >
