[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312581#comment-14312581 ]
Jay Kreps commented on KAFKA-1927: ---------------------------------- Hey [~tongli] Gwen is right that this will be a pretty big chunk of code to move around. By all means go for it if you want to! Usually though it easier to get started with something kind of trivial just to get the mechanics of the code base, review process, etc down. Generally the best starting place is any bug marked with the newbie tag https://issues.apache.org/jira/browse/KAFKA-1926?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20newbie%20AND%20status%20%3D%20Open > Replace requests in kafka.api with requests in > org.apache.kafka.common.requests > ------------------------------------------------------------------------------- > > Key: KAFKA-1927 > URL: https://issues.apache.org/jira/browse/KAFKA-1927 > Project: Kafka > Issue Type: Improvement > Reporter: Jay Kreps > > The common package introduced a better way of defining requests using a new > protocol definition DSL and also includes wrapper objects for these. > We should switch KafkaApis over to use these request definitions and consider > the scala classes deprecated (we probably need to retain some of them for a > while for the scala clients). > This will be a big improvement because > 1. We will have each request now defined in only one place (Protocol.java) > 2. We will have built-in support for multi-version requests > 3. We will have much better error messages (no more cryptic underflow errors) -- This message was sent by Atlassian JIRA (v6.3.4#6332)