----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30355/#review70133 -----------------------------------------------------------
Ship it! Ship It! - Jun Rao On Jan. 28, 2015, 3:09 a.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30355/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 3:09 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1729 > https://issues.apache.org/jira/browse/KAFKA-1729 > > > Repository: kafka > > > Description > ------- > > Add constructor to javaapi to allow constructing explicitly versioned offset > commit requests; provide wrapper javaapi readFrom methods > > > Diffs > ----- > > core/src/main/scala/kafka/api/OffsetCommitResponse.scala > 03dd736494b8ab1d82beb3eac2aa6a616f2b0f0c > core/src/main/scala/kafka/javaapi/ConsumerMetadataResponse.scala > 1b28861cdf7dfb30fc696b54f8f8f05f730f4ece > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala > 873f575cc22af56d980430cde8037324eb754f80 > core/src/main/scala/kafka/javaapi/OffsetCommitResponse.scala > c2d3d114b82a826e5209d7e65b07c06a75ff9420 > core/src/main/scala/kafka/javaapi/OffsetFetchResponse.scala > 60924d2fe543d7c4b5ffe24d1355e1e57211fcc6 > > Diff: https://reviews.apache.org/r/30355/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
