----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30158/#review69515 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java <https://reviews.apache.org/r/30158/#comment114212> I would - for-loop to call Metadata.add(topic). this way we add all topics to Metadata - call Metadata#requestUpdate() to tigger Sender thread to request update for all listed topics clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java <https://reviews.apache.org/r/30158/#comment114215> I would not use initialized flag, as long as we fix KafkaProducer#waitOnMetadata to allow value 0 for non-blocking. - Steven Wu On Jan. 22, 2015, 7:04 a.m., Paul Pearcy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30158/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 7:04 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1835 > https://issues.apache.org/jira/browse/KAFKA-1835 > > > Repository: kafka > > > Description > ------- > > KAFKA-1835 - New producer updates to make blocking behavior explicit > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > fc71710dd5997576d3841a1c3b0f7e19a8c9698e > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > 8b3e565edd1ae04d8d34bd9f1a41e9fa8c880a75 > core/src/test/scala/integration/kafka/api/ProducerBlockingTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > ac15d34425795d5be20c51b01fa1108bdcd66583 > > Diff: https://reviews.apache.org/r/30158/diff/ > > > Testing > ------- > > > Thanks, > > Paul Pearcy > >
