[ https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285979#comment-14285979 ]
Andrii Biletskyi commented on KAFKA-1845: ----------------------------------------- In uploaded patch (KAFKA-1845.patch) all config settings were moved to ConfigDef. ConfigDef.define method requires Importance field. This information is not provided in current trunk version of KafkaConfig, so I used Importance.HIGH everywhere. Please add our comments in review or provide setting to importance map. > KafkaConfig should use ConfigDef > --------------------------------- > > Key: KAFKA-1845 > URL: https://issues.apache.org/jira/browse/KAFKA-1845 > Project: Kafka > Issue Type: Sub-task > Reporter: Gwen Shapira > Assignee: Andrii Biletskyi > Labels: newbie > Attachments: KAFKA-1845.patch > > > ConfigDef is already used for the new producer and for TopicConfig. > Will be nice to standardize and use one configuration and validation library > across the board. -- This message was sent by Atlassian JIRA (v6.3.4#6332)