----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review68569 -----------------------------------------------------------
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala <https://reviews.apache.org/r/24214/#comment112888> Could be simplified to just: for (codec <- CompressionType.values) yield Array(codec.name) - Eric Olander On Jan. 17, 2015, 6:53 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24214/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 6:53 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1374 > https://issues.apache.org/jira/browse/KAFKA-1374 > > > Repository: kafka > > > Description > ------- > > Updating the rebased code > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > f8e7cd5fabce78c248a9027c4bb374a792508675 > core/src/main/scala/kafka/tools/TestLogCleaning.scala > af496f7c547a5ac7a4096a6af325dad0d8feec6f > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 07acd460b1259e0a3f4069b8b8dcd8123ef5810e > > Diff: https://reviews.apache.org/r/24214/diff/ > > > Testing > ------- > > /*TestLogCleaning stress test output for compressed messages/ > > Producing 100000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-6014466306002699464.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-177538909590644701.txt > 100000 rows of data produced, 13165 rows of data consumed (86.8% reduction). > De-duplicating and validating output files... > Validated 9005 values, 0 mismatches. > > Producing 1000000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-3298578695475992991.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-7192293977610206930.txt > 1000000 rows of data produced, 119926 rows of data consumed (88.0% reduction). > De-duplicating and validating output files... > Validated 89947 values, 0 mismatches. > > Producing 10000000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-3336255463347572934.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-9149188270705707725.txt > 10000000 rows of data produced, 1645281 rows of data consumed (83.5% > reduction). > De-duplicating and validating output files... > Validated 899853 values, 0 mismatches. > > > /*TestLogCleaning stress test output for non-compressed messages*/ > > Producing 100000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-5174543709786189363.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-5143455017777144701.txt > 100000 rows of data produced, 22775 rows of data consumed (77.2% reduction). > De-duplicating and validating output files... > Validated 17874 values, 0 mismatches. > > Producing 1000000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-7814446915546169271.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-5172557663160447626.txt > 1000000 rows of data produced, 129230 rows of data consumed (87.1% reduction). > De-duplicating and validating output files... > Validated 89947 values, 0 mismatches. > > Producing 10000000 messages... > Logging produce requests to > /tmp/kafka-log-cleaner-produced-6092986571905399164.txt > Sleeping for 120 seconds... > Consuming messages... > Logging consumed messages to > /tmp/kafka-log-cleaner-consumed-63626021421841220.txt > 10000000 rows of data produced, 1136608 rows of data consumed (88.6% > reduction). > De-duplicating and validating output files... > Validated 899853 values, 0 mismatches. > > > Thanks, > > Manikumar Reddy O > >
