----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/#review67775 -----------------------------------------------------------
Ship it! Reversed an earlier comment, but up to you to pick which one you prefer. core/src/main/scala/kafka/api/OffsetCommitRequest.scala <https://reviews.apache.org/r/29692/#comment111848> Hmm.. actually looking over this I think what you had earlier looks better overall. i.e., maybe changing the field to a var is better? Sorry about that! - Joel Koshy On Jan. 12, 2015, 10:30 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29692/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 10:30 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1841 > https://issues.apache.org/jira/browse/kafka-1841 > > > Repository: kafka > > > Description > ------- > > addressing Joel's comments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java > 7517b879866fc5dad5f8d8ad30636da8bbe7784a > > clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java > 3ee5cbad55ce836fd04bb954dcf6ef2f9bc3288f > core/src/main/scala/kafka/api/OffsetCommitRequest.scala > 861a6cf11dc6b6431fcbbe9de00c74a122f204bd > core/src/main/scala/kafka/api/OffsetCommitResponse.scala > 624a1c1cc540688ae2b1fb96665696a6084158e5 > core/src/main/scala/kafka/api/OffsetFetchRequest.scala > c7604b9cdeb8f46507f04ed7d35fcb3d5f150713 > core/src/main/scala/kafka/server/KafkaApis.scala > 9a61fcba3b5eeb295676b3ef720c719ef5244642 > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala > cd16ced5465d098be7a60498326b2a98c248f343 > > Diff: https://reviews.apache.org/r/29692/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
