> On Jan. 9, 2015, 11:39 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala, line 30 > > <https://reviews.apache.org/r/23702/diff/9/?file=805362#file805362line30> > > > > I think the way you modelled this checkpoint file, which makes it > > different from all other checkpoints we have, is that the metadata > > checkpoints handles the multiple log directories itself. So it is not a > > single broker metadata checkpoint. My only concern with this is that now > > only this checkpoint is very different from other checkpoints. I'd prefer > > we maintain some consistency in all our checkpoints. So modeling log > > directories is fine but then it's desirable if all our checkpoints behaved > > that way. > > > > If you'd prefer changing this checkpoint file to match others, I'd > > suggest- > > > > 1. Change the name to BrokerMetadataCheckpoint. > > 2. Make it take the File that identifies the metadata checkpoint file > > in the constructor > > 3. Change write to not accept the log directories. Just include the > > BrokerMetadata object. > > 4. Similarly include no parameters in the read() API
Followed your suggesstion. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/#review67551 ----------------------------------------------------------- On Jan. 12, 2015, 6:46 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23702/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 6:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1070 > https://issues.apache.org/jira/browse/KAFKA-1070 > > > Repository: kafka > > > Description > ------- > > KAFKA-1070. Auto-assign node id. > > > Diffs > ----- > > core/src/main/scala/kafka/common/GenerateBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaConfig.scala > 6e26c5436feb4629d17f199011f3ebb674aa767f > core/src/main/scala/kafka/server/KafkaServer.scala > 1691ad7fc80ca0b112f68e3ea0cbab265c75b26b > core/src/main/scala/kafka/utils/ZkUtils.scala > 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c9e8ba257b77f46c5c9b62b451470348b6e58889 > > Diff: https://reviews.apache.org/r/23702/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
