> On Jan. 8, 2015, 12:07 p.m., Manikumar Reddy O wrote: > > clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java, > > line 34 > > <https://reviews.apache.org/r/29590/diff/1/?file=806858#file806858line34> > > > > we should support null values right?. This is required for compaction..
That's a good point. Submitted a new RB with the change. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29590/#review67194 ----------------------------------------------------------- On Jan. 5, 2015, 7:47 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29590/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 7:47 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1797 > https://issues.apache.org/jira/browse/kafka-1797 > > > Repository: kafka > > > Description > ------- > > addressing Jay's comments > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/consumer/ByteArrayDeserializer.java > 514cbd2c27a8d1ce13489d315f7880dfade7ffde > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java > 1d64f08762b0c33fcaebde0f41039b327060215a > clients/src/main/java/org/apache/kafka/clients/consumer/Deserializer.java > c774a199db71fbc00776cd1256af57b2d9e55a66 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > fe9066388f4b7910512d85ef088a1b96749735ac > > clients/src/main/java/org/apache/kafka/clients/producer/ByteArraySerializer.java > 9005b74a328c997663232fe3a0999b25d2267efe > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > d859fc588a276eb36bcfd621ae6d7978ad0decdd > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > 9cdc13d6cbb372b350acf90a21538b8ba495d2e8 > clients/src/main/java/org/apache/kafka/clients/producer/Serializer.java > de87f9c1caeadd176195be75d0db43fc0a518380 > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > 3d4ab7228926f50309c07f0672f33416ce4fa37f > > clients/src/main/java/org/apache/kafka/common/errors/DeserializationException.java > a5433398fb9788e260a4250da32e4be607f3f207 > > clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java > PRE-CREATION > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > e194942492324092f811b86f9c1f28f79b366cfd > core/src/main/scala/kafka/tools/ConsoleProducer.scala > 397d80da08c925757649b7d104d8360f56c604c3 > core/src/main/scala/kafka/tools/MirrorMaker.scala > 2126f6e55c5ec6a418165d340cc9a4f445af5045 > core/src/main/scala/kafka/tools/ProducerPerformance.scala > f2dc4ed2f04f0e9656e10b02db5ed1d39c4a4d39 > core/src/main/scala/kafka/tools/ReplayLogProducer.scala > f541987b2876a438c43ea9088ae8fed708ba82a3 > core/src/main/scala/kafka/tools/TestEndToEndLatency.scala > 2ebc7bf643ea91bd93ba37b8e64e8a5a9bb37ece > core/src/main/scala/kafka/tools/TestLogCleaning.scala > b81010ec0fa9835bfe48ce6aad0c491cdc67e7ef > core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala > 1505fd4464dc9ac71cce52d9b64406a21e5e45d2 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > 6196060edf9f1650720ec916f88933953a1daa2c > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 94d0028d8c4907e747aa8a74a13d719b974c97bf > > Diff: https://reviews.apache.org/r/29590/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
