----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/#review65067 -----------------------------------------------------------
Looks good. Just small one nitpick about the test :) core/src/test/scala/unit/kafka/network/SocketServerTest.scala <https://reviews.apache.org/r/29029/#comment108013> you do server.maxConnectionsPerIp+1 because the normal maxConnections is 5 and you override it with 6? Can you just put the number of connections after the override in a variable and use both when creating the override map and in the connection loop? I think this will make the test less fragile and clearer. - Gwen Shapira On Dec. 14, 2014, 5:26 p.m., Jeff Holoman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29029/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2014, 5:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1512 > https://issues.apache.org/jira/browse/KAFKA-1512 > > > Repository: kafka > > > Description > ------- > > KAFKA-1512 write in overrides per previous patch > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > e451592fe358158548117f47a80e807007dd8b98 > core/src/main/scala/kafka/server/KafkaServer.scala > 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe > core/src/test/scala/unit/kafka/network/SocketServerTest.scala > 5f4d85254c384dcc27a5a84f0836ea225d3a901a > > Diff: https://reviews.apache.org/r/29029/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Holoman > >
