----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28479/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1800 https://issues.apache.org/jira/browse/KAFKA-1800 Repository: kafka Description ------- 1. Add the logic for recoding per-topic record error rate in KafkaProducer handling thrown KafkaExceptions; 2. Move the metrics registration from send requests, since for some corner cases the request may not be sent and hence the per-topic metrics would never be registered Diffs ----- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 32f444ebbd27892275af7a0947b86a6b8317a374 clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e Diff: https://reviews.apache.org/r/28479/diff/ Testing ------- Thanks, Guozhang Wang