[
https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225475#comment-14225475
]
Jun Rao commented on KAFKA-1772:
--------------------------------
Thanks for the patch. A few comments on the request/response format.
1. Do we need both utility and command? It's not clear whether all the
combinations make sense. For example, what does Alter/Create producer mean?
Would it be better just to consolidate them to a single field? It would be
useful to document all the commands that we plan to support initially.
2. format: Do we intend to support any format other than json?
3. Could you document the format of the response as well?
4. Does the broker wait until the admin command completes before sending the
response? Commands like partition reassignment can take a long time.
Alternatively, the broker can send the response immediately after the command
is issued. Then, the client can issue a describe command to check the status.
> Add an Admin message type for request response
> ----------------------------------------------
>
> Key: KAFKA-1772
> URL: https://issues.apache.org/jira/browse/KAFKA-1772
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Joe Stein
> Assignee: Andrii Biletskyi
> Fix For: 0.8.3
>
> Attachments: KAFKA-1772.patch
>
>
> - utility int8
> - command int8
> - format int8
> - args variable length bytes
> utility
> 0 - Broker
> 1 - Topic
> 2 - Replication
> 3 - Controller
> 4 - Consumer
> 5 - Producer
> Command
> 0 - Create
> 1 - Alter
> 3 - Delete
> 4 - List
> 5 - Audit
> format
> 0 - JSON
> args e.g. (which would equate to the data structure values == 2,1,0)
> "meta-store": {
> {"zookeeper":"localhost:12913/kafka"}
> }"args": {
> "partitions":
> [
> {"topic": "topic1", "partition": "0"},
> {"topic": "topic1", "partition": "1"},
> {"topic": "topic1", "partition": "2"},
>
> {"topic": "topic2", "partition": "0"},
> {"topic": "topic2", "partition": "1"},
> ]
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
