----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28027/#review61391 -----------------------------------------------------------
Thanks for the patch. I am not sure if that's the right place to fix it though. The issue is that when KafkaController.onControllerResignation() is called, the controller wasn't actually active. A better fix is probably to guard this in onControllerResignation() and only go through the logic if the controller is active. - Jun Rao On Nov. 14, 2014, 1:34 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28027/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 1:34 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1724 > https://issues.apache.org/jira/browse/KAFKA-1724 > > > Repository: kafka > > > Description > ------- > > KAFKA-1724. Errors after reboot in single node setup. > > > Diffs > ----- > > core/src/main/scala/kafka/utils/KafkaScheduler.scala > 9a16343d2ff7192b741f0b23a6bdf58d8f2bbd3e > > Diff: https://reviews.apache.org/r/28027/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
