[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206333#comment-14206333
]
Vladimir Tretyakov edited comment on KAFKA-1481 at 11/11/14 11:42 AM:
----------------------------------------------------------------------
Hi again,
65. Honestly I'd prefer allBrokers=true and allTopics=true or maybe
brokers=aggregated, topics=aggregated.
>From first view user will not know what this is about:
{code}
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964
{code}
and only after user will see something like:
{code}
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964,
broker=0
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964,
broker=1
{code}
user can understand (not sure) that name without 'broker=..' is aggregated
value, I'd prefer explicit definition.
[~jjkoshy] what do you think about:
"brokers=aggregated, topics=aggregated" ? In jconsole user will see
"aggregated" instead of "true", handy from my point of view.
was (Author: vladimir.tretyakov):
Hi again,
65. Honestly I'd prefer allBrokers=true and allTopics=true or maybe
brokers=aggregated, topics=aggregated.
>From first view user will not know what this is about:
{code}
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964
{code}
and only after user will see something like:
{code}
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964,
broker=0
kafka.consumer:type=FetchRequestAndResponseMetrics,name=FetchRequestRateAndTimeMs,clientId=console-consumer-50964,
broker=1
{code}
user can understand (not sure) that like without 'broker=..' is aggregated
value, I'd prefer explicit definition.
[~jjkoshy] what do you think about:
"brokers=aggregated, topics=aggregated" ? In jconsole user will see
"aggregated" instead of "true", handy from my point of view.
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.3
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch,
> KAFKA-1481_2014-10-13_18-23-35.patch, KAFKA-1481_2014-10-14_21-53-35.patch,
> KAFKA-1481_2014-10-15_10-23-35.patch, KAFKA-1481_2014-10-20_23-14-35.patch,
> KAFKA-1481_2014-10-21_09-14-35.patch, KAFKA-1481_2014-10-30_21-35-43.patch,
> KAFKA-1481_2014-10-31_14-35-43.patch,
> KAFKA-1481_2014-11-03_16-39-41_doc.patch,
> KAFKA-1481_2014-11-03_17-02-23.patch,
> KAFKA-1481_2014-11-10_20-39-41_doc.patch,
> KAFKA-1481_2014-11-10_21-02-23.patch,
> KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-15_10-23-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_20-14-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_23-14-35.patch, alternateLayout1.png,
> alternateLayout2.png, diff-for-alternate-layout1.patch,
> diff-for-alternate-layout2.patch, originalLayout.png
>
>
> MBeans should not use dashes or underscores as separators because these
> characters are allowed in hostnames, topics, group and consumer IDs, etc.,
> and these are embedded in MBeans names making it impossible to parse out
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x
> monitoring tools unless they are doing it for themselves AND do not use
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
