> On Nov. 6, 2014, 7:20 p.m., Neha Narkhede wrote: > > Ship It!
Minor nit: Could you change fails to failed? - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27690/#review60215 ----------------------------------------------------------- On Nov. 6, 2014, 5:34 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27690/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:34 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1738 > https://issues.apache.org/jira/browse/kafka-1738 > > > Repository: kafka > > > Description > ------- > > try/catch should include channel.receive() > > > Diffs > ----- > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 > > Diff: https://reviews.apache.org/r/27690/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
