> On Nov. 5, 2014, 1 a.m., Guozhang Wang wrote: > > Where will testcaseEnv.validationStatusDict["Test completed"] be used? > > Ewen Cheslack-Postava wrote: > That's where all the validation results (the test's assertions) are > stored. It gets scanned through at the end of the test run in > system_test_runner.py to generate the report and count the number of > failures. The setup is a bit confusing because it's named by > testcaseEnv.validationStatusDict and > testcaseEnv.testcaseResultsDict["validation_status"] (see TestcaseEnv's > constructor).
I see. Thanks. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review59898 ----------------------------------------------------------- On Nov. 3, 2014, 7:46 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27534/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 7:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1746 > https://issues.apache.org/jira/browse/KAFKA-1746 > > > Repository: kafka > > > Description > ------- > > KAFKA-1746 Make system tests return a useful exit code. > > > KAFKA-1746 Check the exit code when running DumpLogSegments to verify data. > > > Diffs > ----- > > system_test/mirror_maker_testsuite/mirror_maker_test.py > c0117c64cbb7687ca8fbcec6b5c188eb880300ef > system_test/offset_management_testsuite/offset_management_test.py > 12b5cd25140e1eb407dd57eef63d9783257688b2 > system_test/replication_testsuite/replica_basic_test.py > 660006cc253bbae3e7cd9f02601f1c1937dd1714 > system_test/system_test_runner.py ee7aa252333553e8eb0bc046edf968ec99dddb70 > system_test/utils/kafka_system_test_utils.py > 1093b660ebd0cb5ab6d3731d26f151e1bf717f8a > > Diff: https://reviews.apache.org/r/27534/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
