----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58495 -----------------------------------------------------------
Ship it! Just two minor comments that we can touch up on check-in. core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment99544> To make this even clearer, I would name the arguments. i.e., (bufferSize, numInputs = numConsumers, numOutputs = numProducers) core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment99540> Braces are actually unnecessary for the case block - Joel Koshy On Oct. 24, 2014, 7:56 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26994/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 7:56 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1719 > https://issues.apache.org/jira/browse/KAFKA-1719 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Addressed Neha and Guzhang's comments. > > > Incorporated Joel and Neha's comments. > > > Incorporated Joel and Neha's comments. Also fixed a potential race where > cleanShutdown could execute multiple times if several threads exit abnormally > at same time. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > b8698ee1469c8fbc92ccc176d916eb3e28b87867 > > Diff: https://reviews.apache.org/r/26994/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
