----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26503/#review56164 -----------------------------------------------------------
Thanks for the patch. A couple of high level questions. 1. Is the format used in KafkaLZ4BlockInputStream standard? I am wonder if there are libraries in other languages that support this format too. 2. Could you summarize the key difference btw the format in KafkaLZ4BlockInputStream and lz4BlockInputStream? 3. Could we add lz4 in ProducerCompressionTest? clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockInputStream.java <https://reviews.apache.org/r/26503/#comment96483> Should originalLen be compressedLen? clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockInputStream.java <https://reviews.apache.org/r/26503/#comment96484> Should we throw an UnsupportedOperationException? clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockOutputStream.java <https://reviews.apache.org/r/26503/#comment96488> It seems this byte has both the compression method and the compression level. Could we document this? clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockOutputStream.java <https://reviews.apache.org/r/26503/#comment96487> When is finished set to true? - Jun Rao On Oct. 9, 2014, 3:39 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26503/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 3:39 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1493 > https://issues.apache.org/jira/browse/KAFKA-1493 > > > Repository: kafka > > > Description > ------- > > KAFKA-1493 - implemented input/output lz4 streams for kafka message > compression, added compression format description, minor typo fix. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockInputStream.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockOutputStream.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/record/CompressionType.java > 5227b2d7ab803389d1794f48c8232350c05b14fd > clients/src/main/java/org/apache/kafka/common/record/Compressor.java > 0323f5f7032dceb49d820c17a41b78c56591ffc4 > config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 > core/src/main/scala/kafka/message/CompressionCodec.scala > de0a0fade5387db63299c6b112b3c9a5e41d82ec > core/src/main/scala/kafka/message/CompressionFactory.scala > 8420e13d0d8680648df78f22ada4a0d4e3ab8758 > core/src/test/scala/unit/kafka/message/MessageCompressionTest.scala > 6f0addcea64f1e78a4de50ec8135f4d02cebd305 > > Diff: https://reviews.apache.org/r/26503/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
