-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136/#review54990
-----------------------------------------------------------
Thanks for the updated patch. This looks fine - however, wouldn't it be clearer
and less brittle to just name the vals/vars clearly instead of comments?
For. e.g., instead of:
// creating a responseStatusView from partitionStatus, used for
constructing the ProducerResponse
val responseStatus = partitionStatus.mapValues(status =>
status.responseStatus)
we can just do:
val responseStatusView = partitionStatus.mapValues(status =>
status.responseStatus)
- Joel Koshy
On Sept. 16, 2014, 10:23 p.m., Mayuresh Gharat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25136/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2014, 10:23 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1610
> https://issues.apache.org/jira/browse/KAFKA-1610
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Reverting the changes and adding comments to make the usage of mapValues more
> clear
>
>
> Formatted the comments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
> 691d69a49a240f38883d2025afaec26fd61281b5
> core/src/main/scala/kafka/controller/KafkaController.scala
> 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153
> core/src/main/scala/kafka/server/DelayedFetch.scala
> e0f14e25af03e6d4344386dcabc1457ee784d345
> core/src/main/scala/kafka/server/DelayedProduce.scala
> 9481508fc2d6140b36829840c337e557f3d090da
> core/src/main/scala/kafka/server/KafkaApis.scala
> c584b559416b3ee4bcbec5966be4891e0a03eefb
> core/src/main/scala/kafka/server/KafkaServer.scala
> 28711182aaa70eaa623de858bc063cb2613b2a4d
> core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
> af4783646803e58714770c21f8c3352370f26854
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
> c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
>
> Diff: https://reviews.apache.org/r/25136/diff/
>
>
> Testing
> -------
>
> Ran the unit tests and everything passed and the build succeeeded
>
>
> Thanks,
>
> Mayuresh Gharat
>
>
