[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149798#comment-14149798
]
Joel Koshy commented on KAFKA-1577:
-----------------------------------
Oh now I remember this - the root cause is as described above and in my earlier
comment. The original patch only prevents the exception from escaping which
actually causes shutdown to hang. The error is still logged - which I thought
was annoying but can be addressed by logging. From my last comment in the
original RB:
{quote}
Thanks for the patch - this is what I had in mind. The stack trace still shows
up in the log though - I forgot that although swallow keeps the exception from
bubbling up further, it still logs the exception which is annoying.
However, the shutdown no longer hangs (as it used to) so your patch works.
So I think it would be reasonable to just change this to swallow (which means
swallowWarn) and let the exception show up in the logs for now.
There is a separate effort to improve our logging convention and the current
recommendation (for this instance) is to avoid showing the stack trace. That
will be done in the jiras that come out of
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Error+Handling+and+Logging
{quote}
> Exception in ConnectionQuotas while shutting down
> -------------------------------------------------
>
> Key: KAFKA-1577
> URL: https://issues.apache.org/jira/browse/KAFKA-1577
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Joel Koshy
> Assignee: Sriharsha Chintalapani
> Labels: newbie
> Attachments: KAFKA-1577.patch, KAFKA-1577_2014-08-20_19:57:44.patch,
> KAFKA-1577_2014-08-26_07:33:13.patch,
> KAFKA-1577_check_counter_before_decrementing.patch
>
>
> {code}
> [2014-08-07 19:38:08,228] ERROR Uncaught exception in thread
> 'kafka-network-thread-9092-0': (kafka.utils.Utils$)
> java.util.NoSuchElementException: None.get
> at scala.None$.get(Option.scala:185)
> at scala.None$.get(Option.scala:183)
> at kafka.network.ConnectionQuotas.dec(SocketServer.scala:471)
> at kafka.network.AbstractServerThread.close(SocketServer.scala:158)
> at kafka.network.AbstractServerThread.close(SocketServer.scala:150)
> at kafka.network.AbstractServerThread.closeAll(SocketServer.scala:171)
> at kafka.network.Processor.run(SocketServer.scala:338)
> at java.lang.Thread.run(Thread.java:662)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
