Hi David, Thanks for the review!
I agree with both suggestions and have updated the KIP accordingly. Best, Nick On Thu, May 28, 2026 at 4:29 PM David Jacot via dev <[email protected]> wrote: > Hi Nick, > > Thanks for the KIP. > > DJ_01: Could you please provide the full metric name in the KIP? It is a > bit hard to follow the names in the table. You can use the format that we > used in KIP-848 and KIP-1071. > DJ_02: I wonder if we should change `group-offset-count` to `offset-count` > to follow the `group-count` pattern. > > Otherwise, the KIP looks good to me. > > Best, > David > > On Tue, May 12, 2026 at 9:23 AM Nick Guo <[email protected]> wrote: > > > Hi Chia-Ping, > > > > I've updated both. Thanks > > > > On Mon, May 11, 2026 at 1:26 AM Chia-Ping Tsai <[email protected]> > > wrote: > > > > > hi Nick > > > > > > chia_02: please fill out the test plan > > > > > > chia_03: please update the vote link > > > > > > Best, > > > Chia-Ping > > > > > > On 2026/04/07 06:55:34 Nick Guo wrote: > > > > Hi all, > > > > > > > > I would like to start a discussion on > > > > KIP-1301: Deprecate Yammer-based metrics in > `GroupCoordinatorMetrics`. > > > > > > > https://urldefense.com/v3/__https://cwiki.apache.org/confluence/x/Z5U8G__;!!Ayb5sqE7!sDdh1qD64xtF14552rDZJo0UApd0GJV0NUB9Wr76MRnQUAYzNN40rsR_njmVEcpl4EpUOS_j1i0xmjeGNOLv$ > > > > > > > > This KIP proposes deprecating the remaining legacy Yammer metrics in > ` > > > > GroupCoordinatorMetrics` and replacing them with standard Kafka > > Metrics. > > > > This will complete the migration and fully unify the group > > coordinator's > > > > metrics interface. > > > > > > > > Looking forward to hearing your thoughts. > > > > > > > > Thanks, > > > > Nick > > > > > > > > > >
