+1 (binding) Thanks, Andrew
On 2026/05/30 04:48:20 Chia-Ping Tsai wrote: > +1 (binding) > > BTW, l left a small comment on the discussion thread > > Best, > Chia-Ping > > On 2026/05/28 21:01:08 Aditya Kousik wrote: > > Hi all, > > > > Following up here on further discussion in code review. In the last design, > > we proposed to make all methods with a default empty body. This breaks > > source compatibility for Scala requiring an override def. > > > > To address this, I’ve changed the design slightly that will position the > > improvement a bit better. I’ve introduced a new super interface > > RebalanceListener with exactly the same shape as ConsumerRebalanceListener > > but with the extra parameter RebalanceConsumer. The existing interface will > > simply extend it overriding with defaults to the 1-arg methods . We also > > mark ConsumerRebalanceListener as deprecated. > > > > Relatedly the set method on Consumer will be setRebalanceListener. > > > > In light of this major change, I wanted to re-open the vote so that > > everyone is onboard with the proposed changes. > > > > Do let me know your thoughts. > > > > GitHub discussion: > > https://github.com/apache/kafka/pull/22270#discussion_r3312040954 > > Updated KIP: https://cwiki.apache.org/confluence/x/9ZU8G > > Original discussion thread: > > https://lists.apache.org/thread/8nmybx73f0tmjlb56sdophvoy4yomlx2 > > > > With regards, > > Aditya Kousik >
