chia7712 commented on code in PR #874:
URL: https://github.com/apache/kafka-site/pull/874#discussion_r3329108930


##########
content/en/43/streams/developer-guide/config-streams.md:
##########
@@ -1365,7 +1365,7 @@ Serde for the inner class of a windowed record. Must 
implement the `Serde` inter
 
 ### group.protocol
 
-> The group protocol used by the Kafka Streams client used for coordination. 
It determines how the client will communicate with the Kafka brokers and other 
clients in the same group. The default value is `"classic"`, which is the 
classic consumer group protocol. Can be set to `"streams"` (requires 
broker-side enablement) to enable the new Kafka Streams group protocol.
+> The group protocol used by the Kafka Streams client used for coordination. 
It determines how the client will communicate with the Kafka brokers and other 
clients in the same group. The default value is `"classic"`, which is the 
classic consumer group protocol. Can be set to `"streams"` (requires 
broker-side enablement) to enable the new Kafka Streams group protocol. Note 
that the "streams" rebalance protocol is an Early Access feature and should not 
be used in production. 

Review Comment:
   Why did you add this outdated description back? see 
https://github.com/apache/kafka-site/commit/3e46e673398110d5209063d824ab7d8d6a7adbac



##########
content/en/43/operations/monitoring.md:
##########
@@ -5081,7 +5081,7 @@ 
kafka.streams:type=stream-topic-metrics,thread-id=([-.\w]+),task-id=([-.\w]+),pr
 
 ### State Store Metrics
 
-All the following metrics have a recording level of `debug`, except for the 
`record-e2e-latency-*` metrics which have a recording level `trace` and 
`num-open-iterators` and `num-keys` which have recording level `info`. Note 
that the `store-scope` value is specified in `StoreSupplier#metricsScope()` for 
user's customized state stores; for built-in state stores, currently we have:
+All the following metrics have a recording level of `debug`, except for the 
`record-e2e-latency-*` metrics which have a recording level `trace` and 
`num-open-iterators` and `num-keys` which have recording level `info`. Note 
that the `store-scope` value is specified in `StoreSupplier#metricsScope()` for 
user's customized state stores; for built-in state stores, currently we have: 

Review Comment:
   this change seems to be caused by fat finger



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to