Chia-Ping Tsai created KAFKA-20546:
--------------------------------------

             Summary: Lazily call generateNewClientId when handling 
GetTelemetrySubscriptionsRequest
                 Key: KAFKA-20546
                 URL: https://issues.apache.org/jira/browse/KAFKA-20546
             Project: Kafka
          Issue Type: Improvement
            Reporter: Chia-Ping Tsai


KIP-1313 will let GetTelemetrySubscriptionsRequest carry the client instance 
id, so it is time to apply the lazy policy

https://cwiki.apache.org/confluence/x/Jpc8G

related code: 
https://github.com/apache/kafka/blob/trunk/server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java#L165

        Uuid clientInstanceId = 
Optional.ofNullable(request.data().clientInstanceId())
            .filter(id -> !id.equals(Uuid.ZERO_UUID))
            .orElse(generateNewClientId());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to