Hi Jiunn-Yang, Thanks very much for looking into these inconsistencies, thoroughly documenting them and proposing a fix.
This is minor but in the public interface section you have: "Update the processing logic in ControllerApis#handleIncrementalAlterConfigs." Technically, that method is not part of Kafka's public interface. This KIP doesn't change any public interfaces. It is okay to just state that in the public interfaces section. In the proposed changes section you include code for the change. It is difficult to evaluate the code since it is not clear to me what is the implementation for some of the symbols included. In the motivation section you enumerated all of the inconsistency between the broker and the controller. What do you think of adding a similar enumeration in the proposed changes section explaining how you plan to resolve those inconsistencies? Thanks, -- -José
