+1 (binding) jian fu <[email protected]> 於 2025年12月23日週二 下午9:06寫道：
> Hi Andrew： > > Thanks for your review and vote. We only need one more vote now. > By the way, Merry Christmas! > > Regards > Jian > > Andrew Schofield <[email protected]> 于2025年12月23日周二 01:28写道： > > > Hi Jian, > > Thanks for the KIP. > > > > +1 (binding) > > > > Andrew > > > > On 17 Dec 2025, at 13:03, jian fu <[email protected]> wrote: > > > > Hi Kamal: > > > > Thanks for your vote ! > > > > Regards > > Jian > > > > Kamal Chandraprakash <[email protected]<mailto: > > [email protected]>> 于2025年12月16日周二 > > 23:03写道： > > > > Hi Jian, > > > > +1 (binding). Thanks for the KIP! > > > > Thanks, > > Kamal. > > > > On Wed, Dec 10, 2025 at 10:37 AM jian fu <[email protected]> wrote: > > > > sorry. resent with formatted email content > > > > Hi all, I'd like to initiate the vote for KIP-1235 right away as it's a > > minor change with minimal risk. > > > > Summary: Currently, __remote_log_metadata relies on the broker default > > for > > min.isr (typically 1). With min.isr=1 and factor=3, acknowledged writes > > can > > be lost if the leader crashes before replication completes, making remote > > data permanently unreachable. > > > > What's more, the similar topic: __transaction_state sets min.isr=2 via > > transaction.state.log.min.isr.We should provide the same durability for > > __remote_log_metadata. Proposed Change: Add one new broker config: > > remote.log.metadata.topic.min.isr (default: 2) When creating > > __remote_log_metadata, TopicBasedRemoteLogMetadataManager will set > > min.insync.replicas=2 at the topic level. > > > > KIP WIKI: > > > > > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-1235%253A%2BCorrect%2Bthe%2Bdefault%2Bmin.insync.replicas%2Bto%2B2%2Bfor%2Bthe%2B__remote_log_metadata%2Btopic&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277583702%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=G%2B%2FWVmxcfAlyzkXquGAoFjSI1cDPmVa8lplZdd8luf4%3D&reserved=0 > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1235%3A+Correct+the+default+min.insync.replicas+to+2+for+the+__remote_log_metadata+topic > > > > > > > Discussion Thread: > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2F016mjw3rrcqnt8475bxr3b3npm0t32xl&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277646998%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=kA8Evc7anxf3D1OyDX4IaVqo8fb0M9%2F%2FBqB1Ez4D6hE%3D&reserved=0 > > <https://lists.apache.org/thread/016mjw3rrcqnt8475bxr3b3npm0t32xl> > > PR: > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fkafka%2Fpull%2F20811&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277703495%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=DWtY%2FyO4ffR%2Fxib2dwtr45F3JabwqjAfcV1c5TKEfzY%3D&reserved=0 > > <https://github.com/apache/kafka/pull/20811> > > > > Looking forward to your feedback! > > Thanks! > > > > Regards > > Jian > > > > jian fu <[email protected]<mailto:[email protected]>> > > 于2025年12月10日周三 12:51写道： > > > > Hi all, I'd like to initiate the vote for KIP-1235 right away as it's a > > minor change with minimal risk. Summary: Currently, > > __remote_log_metadata > > relies on the broker default for min.isr (typically 1). With min.isr=1 > > and > > factor=3, acknowledged writes can be lost if the leader crashes before > > replication completes, making remote data permanently unreachable. > > What's > > more, the similar topic: __transaction_state sets min.isr=2 via > > transaction.state.log.min.isr.We should provide the same durability for > > __remote_log_metadata. Proposed Change: Add one new broker config: > > remote.log.metadata.topic.min.isr (default: 2) When creating > > __remote_log_metadata, TopicBasedRemoteLogMetadataManager will set > > min.insync.replicas=2 at the topic level. KIP WIKI: > > > > > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-1235%253A%2BCorrect%2Bthe%2Bdefault%2Bmin.insync.replicas%2Bto%2B2%2Bfor%2Bthe%2B__remote_log_metadata%2Btopic&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277759776%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=8tV6VqJiN9iCL7JMkj8hDNgapRcXBuvAZccPfM6ZZlw%3D&reserved=0 > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1235%3A+Correct+the+default+min.insync.replicas+to+2+for+the+__remote_log_metadata+topic > > > > > Discussion Thread: > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2F016mjw3rrcqnt8475bxr3b3npm0t32xl&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277810649%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=%2B4NWFXZWzGGG0idzP0%2BmIuXwTTbRIpzNFybT3oEnDAQ%3D&reserved=0 > > <https://lists.apache.org/thread/016mjw3rrcqnt8475bxr3b3npm0t32xl> PR: > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fkafka%2Fpull%2F20811&data=05%7C02%7C%7C91da67743e5549bde91a08de3d6cf14e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C639015735277856392%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=pJe2MvXP3cZoc4wnJRC%2Fkxknpu%2Fm9APT1t%2FpCB%2Fr5cg%3D&reserved=0 > > <https://github.com/apache/kafka/pull/20811> Looking forward to your > > feedback! Thanks! Regards Jian > > > > >
