[ https://issues.apache.org/jira/browse/KAFKA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139192#comment-14139192 ]
Guozhang Wang commented on KAFKA-1591: -------------------------------------- Thanks for the patch, a few more comments below: 2.0. The patch cannot be applied to latest trunk, could you rebase? 2.1. In ClientUtils, could you also print the e.toString? 2.2. In in ReplicaManager, it may be useful to keep the stack trace for "Error on broker %d while processing LeaderAndIsr ...". The reasons is that this error may be thrown from different underlying modules, or even a non-Kafka exception (we are catching Throwable here). And the upper level KafkaApis will not log the stack trace either when it catches this re-thrown error. > Clean-up Unnecessary stack trace in error/warn logs > --------------------------------------------------- > > Key: KAFKA-1591 > URL: https://issues.apache.org/jira/browse/KAFKA-1591 > Project: Kafka > Issue Type: Bug > Reporter: Guozhang Wang > Assignee: Abhishek Sharma > Labels: newbie > Fix For: 0.9.0 > > Attachments: Jira-1591- Complete Changes Patch.patch, > Jira-1591-SocketConnection-Warning.patch, > Jira1591-SendProducerRequest-Warning.patch > > > Some of the unnecessary stack traces in error / warning log entries can > easily pollute the log files. Examples include KAFKA-1066, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)