[ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137568#comment-14137568 ]
Jun Rao commented on KAFKA-1123: -------------------------------- Thanks for the patch. Looks good overall. Some minor comments below. 1. ClientUitls: There is still one place that references "bootstrap url". We can change it to use the BOOTSTRAP constant. 2. Broker: redundant import of kafka.util.Utils. 3. DataGenerator, TopicMetadata: unused import kafka.util.Utils 4. UtilsTest.testParseHostPort seems can be testParsePort? 5. ClientUtilsTest: Do we need to test "[2001:db8:85a3:8d3:1319:8a2e:370:7348]:1234" twice? 6. Could you rebase? > Broker IPv6 addresses parsed incorrectly > ---------------------------------------- > > Key: KAFKA-1123 > URL: https://issues.apache.org/jira/browse/KAFKA-1123 > Project: Kafka > Issue Type: Bug > Components: producer > Affects Versions: 0.8.2 > Reporter: Andrew Otto > Labels: newbie > Attachments: KAFKA-1123.patch, KAFKA-1123_v2.patch > > > It seems that broker addresses are parsed incorrectly when IPv6 addresses are > supplied. IPv6 addresses have colons in them, and Kafka seems to be > interpreting the first : as the address:port separator. > I have only tried this with the console-producer --broker-list option, so I > don't know if this affects anything deeper than the CLI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)