Hi Kirk,

Thanks for review this KIP!

KT1 & KT3:
Since some configs can be set to null or empty string, and their behavior
depends on how each config is defined (KIP-1161 discusses this in detail)
and may change over time, I prefer that the values be used
verbatim, because invalid values will still raise errors when creating
Kafka components (producer, consumer, admin, etc.).

KT2:
That sounds like a good idea. I’ll modify mergePropertiesWithPrecedence to
issue warnings when the same config appears in multiple sources. I’ll
update the KIP accordingly.

KT4:
How about modern-order, modern-config-order, or standard-config-order if
“precedence” is hard to type? Naming things is hard :)


Yung

Reply via email to