[
https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135561#comment-14135561
]
Nicolae Marasoiu edited comment on KAFKA-1282 at 9/16/14 3:00 PM:
------------------------------------------------------------------
Hi,
I have understood what you say and I agree it is highly unintuitive and we
should change that. I just saw you propose a solution which included a
precomputation of the time to close, and it was bit confusion, looked like an
attempt of micro optimization.
I have not made any patch yet, I waited for feedback from Neha too, but I will
do the patch today: it looks ok to me the idea of closing at most one old
connection per selector iteration.
So the solution will look more like the previous patch, but instead of
traversing n+1 entries to close n old connections, it will just pick the oldest
and check if it is time to close.
For #1, the way Neha and me discussed, and the way you understood it works (for
the latest patch), is that an old connection is taken into consideration for
close only when a new connection is being opened up (or activity exists on an
existing connection too). But this will no longer be the case.
was (Author: nmarasoiu):
Hi, I have not made any patch yet, I waited for feedback from Neha too, but I
will do the patch today, it looks ok to me the idea of closing at most one old
connection per selector iteration.
For #1, the way Neha and me discussed, and the way you understood it works (for
the latest patch), is that an old connection is taken into consideration for
close only when a new connection is being opened up (or activity exists on an
existing connection too).
> Disconnect idle socket connection in Selector
> ---------------------------------------------
>
> Key: KAFKA-1282
> URL: https://issues.apache.org/jira/browse/KAFKA-1282
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.8.2
> Reporter: Jun Rao
> Assignee: nicu marasoiu
> Labels: newbie++
> Fix For: 0.9.0
>
> Attachments:
> KAFKA-1282_Disconnect_idle_socket_connection_in_Selector.patch,
> idleDisconnect.patch
>
>
> To reduce # socket connections, it would be useful for the new producer to
> close socket connections that are idle. We can introduce a new producer
> config for the idle time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
