[ https://issues.apache.org/jira/browse/KAFKA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anton Karamanov updated KAFKA-1620: ----------------------------------- Attachment: 0002-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch Not really. I just thought it might become useful at some point as well. I took a closer look and now realize that it's related to internal messages, so there's no actual need to make them public. Here's updated and rebased [patch|^0002-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch]. > Make kafka api protocol implementation public > --------------------------------------------- > > Key: KAFKA-1620 > URL: https://issues.apache.org/jira/browse/KAFKA-1620 > Project: Kafka > Issue Type: Improvement > Reporter: Anton Karamanov > Assignee: Anton Karamanov > Attachments: > 0001-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch, > 0002-KAFKA-1620-Make-kafka-api-protocol-implementation-pu.patch > > > Some of the classes which implement Kafka api protocol, such as > {{RequestOrResponse}} and {{FetchRequest}} are defined as private to > {{kafka}} package. Those classes would be extremely usefull for writing > custom clients (we're using Scala with Akka and implementing one directly on > top of Akka TCP), and don't seem to contain any actuall internal logic of > Kafka. Therefore it seems like a nice idea to make them public. -- This message was sent by Atlassian JIRA (v6.3.4#6332)