Hello Jun, Thanks for the reply.
I have updated the KIP according there comments. Best Regards, Jiunn-Yang > Jun Rao <j...@confluent.io.INVALID> 於 2025年8月13日 凌晨1:57 寫道： > > Hi, Jiunn-Yang, > > Thanks for the reply. A few more comments. > > JR50. It seems that you changed the default value for config.providers > incorrectly. The change is meant for bootstrap.servers. > > JR51. Could you document the current behavior if bootstrap.servers is empty > in ConsumerConfig, WorkerConfig, ProducerConfig and StreamsConfig? > > JR52. Could you document the justification for changing the default value > for bootstrap.servers in WorkerConfig? > > JR53. It seems that WorkerConfig is not public facing. Only classes in > connect api are public. So, there is no need to document the deprecation > of BOOTSTRAP_SERVERS_DEFAULT in WorkerConfig. > > Jun > > > On Tue, Aug 12, 2025 at 8:14 AM 黃竣陽 <s7133...@gmail.com> wrote: > >> Hi chia, >> >> I have updated the KIP with these changes. >> >> Best Regards, >> Jiunn-Yang >> >>> Chia-Ping Tsai <chia7...@gmail.com> 於 2025年8月12日 晚上9:54 寫道： >>> >>> hi Jiunn >>> >>>> 黃竣陽 <s7133...@gmail.com> 於 2025年8月12日 下午6:18 寫道： >>>> >>>> 3. WorkerConfig – Change the default value of bootstrap.servers from >> "localhost:9092" to NO_DEFAULT_VALUE >>>> and deprecate the constant BOOTSTRAP_SERVERS_DEFAULT. >>> >>> >>> I agree that the default value of “localhost:9092” is strange. However, >> it is still a breaking change, so please highlight this change in the KIP. >>> >>> Best, >>> Chia-Ping >> >>
