Hi Luke
Thanks for your feedback!
L1, L2: The logic for
`RemoteLogManagerConfig#remoteLogManagerFollowerThreadPoolSize` is shown
below.
```
public int remoteLogManagerFollowerThreadPoolSize() {
if
(config.originals().containsKey(REMOTE_LOG_MANAGER_FOLLOWER_THREAD_POOL_SIZE_PROP))
{
return
config.getInt(REMOTE_LOG_MANAGER_FOLLOWER_THREAD_POOL_SIZE_PROP);
} else {
return config.getInt(REMOTE_LOG_MANAGER_THREAD_POOL_SIZE_PROP);
}
}
```
This method first checks whether the user has explicitly set
remote.log.manager.follower.thread.pool.size.
If not, it falls back to remote.log.manager.thread.pool.size.
So remote.log.manager.follower.thread.pool.size always takes precedence,
regardless of whether it's configured statically in the broker config file
or dynamically at runtime.
For example, if the user sets remote.log.manager.thread.pool.size=10 and
later
dynamically configures remote.log.manager.follower.thread.pool.size=8, the
follower thread pool size will be 8.
I’ll also update this example in the "Compatibility, Deprecation, and
Migration Plan" section.
Best,
Kuan-Po
On Tue, May 20, 2025 at 10:43 AM Luke Chen <show...@gmail.com> wrote:
> Hi Kuan-Po,
>
> Thanks for the KIP!
>
> Questions:
> 1. If `remote.log.manager.thread.pool.size` is set and
> `remote.log.manager.follower.thread.pool.size` is not set, we will still
> honor the setting in `remote.log.manager.thread.pool.size`, right? We
> should add in KIP to make it clear.
>
> 2. Suppose `remote.log.manager.thread.pool.size=10` and
> `remote.log.manager.follower.thread.pool.size` is not set, could we do
> dynamically config change to `remote.log.manager.follower.thread.pool.size`
> config? The value of will be `remote.log.manager.follower.thread.pool.size`
> 10 or default 2?
>
> Thank you.
> Luke
>
>
> On Tue, May 20, 2025 at 9:28 AM Kuan-Po Tseng <brandb...@gmail.com> wrote:
>
> > Hello everyone,
> >
> > Just giving this thread a little nudge. If there’s no more feedback, I’ll
> > kick off the vote tomorrow.
> > Also, thanks to Kamal for reviewing this KIP!
> >
> > Best Regards,
> > Kuan-Po
> >
> > On Mon, May 19, 2025 at 11:16 PM Kamal Chandraprakash <
> > kamal.chandraprak...@gmail.com> wrote:
> >
> > > Hi Kuan-Po,
> > >
> > > The proposal to add the new
> remote.log.manager.follower.thread.pool.size
> > > config, LGTM.
> > > Thanks for making this change!
> > >
> > > --
> > > Kamal
> > >
> > > On Mon, May 12, 2025 at 10:19 PM KuanPo Tseng <brandb...@apache.org>
> > > wrote:
> > >
> > > > Hello everyone,
> > > >
> > > > I’d like to discuss a KIP regarding introducing a new configuration,
> > > > remote.log.manager.follower.thread.pool.size
> > > >
> > > > Thank you!
> > > >
> > > > KIP link: https://cwiki.apache.org/confluence/x/xAlWFQ
> > > >
> > > > Best,
> > > > Kuan-Po Tseng
> > > >
> > >
> >
>
