Hi Kevin Thanks for this great KIP! +1 (binding)
Best, TengYao Chia-Ping Tsai <chia7...@apache.org> 於 2025年4月29日 週二 下午4:15寫道： > hi Kevin > > PoAn is not yet a Kafka committer. I hope he can make more contributions > to get promoted. > > Regarding the KIP, it looks good to me. +1 (binding) > > One small question: > > Why use "number" instead of "string" to represent the state? There are > other state-related metrics, such as "current-state", that use "string", so > I'm curious about the design rationale. > > thanks, > Chia-Ping > > On 2025/04/28 17:19:42 Kevin Wu wrote: > > Hey PoAn, > > > > I might be wrong, but I thought you were a committer? If so, are you > > willing to change your vote to be binding if the changes look good, so > the > > KIP is accepted? > > > > Best regards, > > Kevin > > > > On Tue, Mar 25, 2025 at 5:29 PM Kevin Wu <kevin.wu2...@gmail.com> wrote: > > > > > Hello all, > > > > > > I am manually bumping this thread. > > > Any feedback or votes would be appreciated. > > > > > > Best regards, > > > Kevin Wu > > > > > > On Thu, Mar 13, 2025 at 1:54 PM Kevin Wu <kevin.wu2...@gmail.com> > wrote: > > > > > >> Hello all, > > >> > > >> I would like to call a vote for KIP-1131: Improved controller-side > > >> monitoring of broker states. > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1131%3A+Improved+controller-side+monitoring+of+broker+states > > >> > > >> Discussion thread: > > >> https://lists.apache.org/thread/z8cwnksl6op4jfg7j0nwsg9xxsf8mwhh > > >> > > >> Thanks for the reviews, > > >> Kevin Wu > > >> > > >> > > >
