Thanks for the improvement Kevin. I got a chance to look at the KIP.

1.  kafka.controller:type=KafkaController,name=BrokerRegistrationState.kafka-X

Can we use tags or attributes instead of different names? For example,
how about 
kafka.controller:type=KafkaController,name=BrokerRegistrationState,broker=X
where X is the node id?

2. 
kafka.controller:type=KafkaController,name=TimeSinceLastHeartbeatReceivedMs.kafka-X

Same here, did you consider using tags or attributes for the node id?

3. For the metrics
kafka.controller:type=KafkaController,name=TimeSinceLastHeartbeatReceivedMs.kafka-X,
you mentioned that you will limit the value to the heartbeat timeout.
Why? Wouldn't it be a useful report the entire time since the last
heartbeat? That is more information instead of just reporting the
value up to the heartbeat timeout.

Thanks,
-- 
-José

Reply via email to