Hi, Calvin, Thanks for the KIP. Just a minor comment.
ListTransactionRequest no longer supports zkBroker. Jun On Wed, Apr 2, 2025 at 9:43 AM Calvin Liu <ca...@confluent.io.invalid> wrote: > Hi Artem, > Thanks for the advice. It makes sense to make it only fail when using the > new filter. > Thanks > > On Tue, Apr 1, 2025 at 4:27 PM Artem Livshits > <alivsh...@confluent.io.invalid> wrote: > > > Hi Calvin, > > > > Thanks for the KIP. > > > > [AL1] > > > When the cluster does not support the new version, the admin client > will > > fail to build the ListTransaction request with version 2. > > UnsupportedVersionException will be thrown. > > > > It looks like this will make it impossible to use newer clients with > older > > brokers, which would break backward compatibility. Instead of this, we > > should do what > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs > > did, when it added a new filter: the client should only fail when the new > > filter is used and the broker doesn't support the new filter. > > > > -Artem > > > > On Tue, Apr 1, 2025 at 4:18 PM Calvin Liu <ca...@confluent.io.invalid> > > wrote: > > > > > Hi Kafka Community, > > > I would like to start a discussion on KIP-1152: Add transactional ID > > prefix > > > filter to ListTransactions API > > > The main motivation behind the KIP is to reduce the transactions > included > > > in the ListTransactions response when the transactional IDs are > > > well-formatted and can be fetched with a prefix. > > > > > > The KIP will update the ListTransaction APIs, ListTransactionOptions > and > > > kafka-transactions.sh > > > Thanks! > > > > > > Link to the KIP. > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1152%3A+Add+transactional+ID+prefix+filter+to+ListTransactions+API > > > > > >
