Chia-Ping Tsai created KAFKA-18735: -------------------------------------- Summary: the zk-related path `<default>` is still existent in quota system, such as `ConfigEntity#name` and metrics tags Key: KAFKA-18735 URL: https://issues.apache.org/jira/browse/KAFKA-18735 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai
the `<default>` is a specific "flag" used by zk path to represent the "default" quota. We don't expose it on Admin as we use `null` to represent the default name [0], and in KAFKA-16411 we assumes `<default>` should be removed from 4.0 with the end of ZK mode [1] However, the `<default>` is still used in two "public APIs" 1. ConfigEntity#name return <default> for default quotas. The docs say it return empty string, but that is incorrect. see [2] 2. "client-id" -> "<default>" and "user" -> "<default>" are used in metrics tag [3] [0] https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java#L44 [1] https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/config/ZooKeeperInternals.java#L24 [2] https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ClientQuotaManager.scala#L79 [3] https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ClientQuotaManager.scala#L479 -- This message was sent by Atlassian Jira (v8.20.10#820010)