Hi everyone, I'd like to discuss the leave callback implementation. While this KIP focuses on sending leave requests, we should also consider how to handle the leave callback. IMHO, we should maintain the original logic: if a consumer remains in the group, the callback should not be invoked.
What do you think? Best regards, TengYao TengYao Chi <kiting...@gmail.com> 於 2024年10月2日 週三 下午7:02寫道： > Hello everyone, > > It seems we have reached a consensus on how this KIP will proceed. > I have updated the content accordingly. > Please take a look, and if there are no further questions, I will initiate > a vote. > > Best regards, > TengYao > > Chia-Ping Tsai <chia7...@gmail.com> 於 2024年10月2日 週三 上午7:06寫道： > >> hi Matthias >> >> Thanks for sharing your POV, and you do remind me that this KIP should >> not be blocked due to this verbose discussion. >> >> Those protected methods are not Public APIs, so they can reverted without >> deprecation cycle. Those variables can be exposed publicly when users do >> need them. >> >> +1 to clean user facing API >> >> Best, >> Chia-Ping >> >> > Matthias J. Sax <mj...@apache.org> 於 2024年10月2日 凌晨2:38 寫道： >> > Yes, it requires an internal class. But I would rather optimize for a >> clean user facing API. Personally, I don't think it will make our code base >> significantly more complex, so I think it's worth the tradeoff. >> > >> > And yes, we would need to take user provided `CloseOption` object and >> create `CloseOptionInternal` object, but as it's not on the hot code path, >> and both objects are short lived anyway, it seems >> >
