[ 
https://issues.apache.org/jira/browse/KAFKA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai resolved KAFKA-18181.
------------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

> Refactor ShareConsumerTest
> --------------------------
>
>                 Key: KAFKA-18181
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18181
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Kuan Po Tseng
>            Priority: Major
>             Fix For: 4.0.0
>
>
> 1. `consumeMessages` should return `messagesConsumed` instead of wrapping it 
> in `CompletableFuture`
> 2. replace `fail` by `assertDoesNotThrow` or just throw exception
> 3. `produceMessages`should return `messagesConsumed` instead of wrapping it 
> in `CompletableFuture`
> 4. use `CompletableFuture.runAsync()` instead of ExecutorService. We don't 
> use the interrupt so it is fine to use default executor



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to