Hi all, When implementing ConsumerGroupDescribeResponse, we change IsClassic field from bool to int8. The field is introduced by RPC version 1. The default value “false” is equivocal, because it means unknown or not a classic member. The client side has to distinguish it by RPC version. To fix this, we change it to int8 and use -1 as default value for unknown. 0 for consumer member and +1 for classic member.
We also change MemberDescription#isClassic from boolean to Optional<Boolean>, so we can use Optional.empty() for unknown case. PR discussion thread: https://github.com/apache/kafka/pull/17958#discussion_r1865801241 Regards, PoAn > On Nov 28, 2024, at 8:27 PM, PoAn Yang <yangp...@gmail.com> wrote: > > Hi Lucas, > > Thanks for the reminder. Yes, we can use an unboxed boolean. > Update the KIP. > > Thanks, > PoAn > >> On Nov 28, 2024, at 8:23 PM, Lucas Brutschy <lbruts...@confluent.io.INVALID> >> wrote: >> >> Hi PoAn, >> >> a minor follow-up question. The isClassic boolean in the Admin API, >> seems to use a boxed type `Boolean` instead of an unboxed boolean. It >> seems we could use the unboxed type here. >> >> Cheers, >> Lucas >> >> On Tue, Nov 26, 2024 at 1:55 AM PoAn Yang <yangp...@gmail.com> wrote: >>> >>> Hi everyone, >>> >>> Thanks for your voting. >>> >>> The KIP passes with 4 +1 (binding) votes from Chia-Ping Tsai, >>> David Jacot, Lianet M., Jeff Kim and 1 +1 (non-binding) from Andrew >>> Schofield. >>> >>> Thank you. >>> >>> Best, >>> PoAn >>> >>>> On Nov 26, 2024, at 12:39 AM, Jeff Kim <jeffkb...@apache.org> wrote: >>>> >>>> Thanks! >>>> >>>> +1 (binding) >>>> >>>> Jeff >>>> >>>> On 2024/11/25 15:46:04 "Lianet M." wrote: >>>>> Thanks for the KIP and updates PoAn! >>>>> >>>>> +1 (binding) >>>>> >>>>> Lianet >>>>> >>>>> On Mon, Nov 25, 2024, 10:43 a.m. Andrew Schofield < >>>>> andrew_schofield_j...@outlook.com> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> Thanks, >>>>>> Andrew >>>>>> >>>>>> ________________________________________ >>>>>> From: David Jacot <dja...@confluent.io.INVALID> >>>>>> Sent: 25 November 2024 15:38 >>>>>> To: dev@kafka.apache.org <dev@kafka.apache.org> >>>>>> Subject: Re: [VOTE] KIP-1099: Extend kafka-consumer-groups command line >>>>>> tool to support new consumer group >>>>>> >>>>>> +1 (binding) >>>>>> >>>>>> In gmail, the discuss and the vote threads got merged somehow. >>>>>> >>>>>> On Wed, Nov 20, 2024 at 4:47 AM Chia-Ping Tsai <chia7...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> +1 (binding) >>>>>>> >>>>>>> On 2024/11/18 14:52:22 PoAn Yang wrote: >>>>>>>> Hi All, >>>>>>>> >>>>>>>> I would like to start vote on KIP-1099: >>>>>>>> >>>>>>> >>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group >>>>>>>> >>>>>>>> Discussion thread: >>>>>>>> https://lists.apache.org/thread/lo64123wm3kjmjsx72xg67wvjx9nykk8 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> PoAn >>>>>>> >>>>>> >>>>> >>> >
