Hi Divij, One comment: For the default value of "num.recovery.threads.per.data.dir", we change from 1 to 2. Could we change the value based on the CPU core number? Ex: default value = CPU core num / num of log dirs.
WDYT? Luke On Wed, Nov 20, 2024 at 5:53 PM Tommi Vainikainen <tvain...@aiven.io.invalid> wrote: > Hi, > > This proposal looks good to me with new defaults and constraints. > > About breaking backward compatibility I've question on how you see it best > handled in case someone upgrades Kafka cluster from 3.9 to 4.0 with let's > say one topic having segment.bytes=500 kb (new min is 1 MB). Does it mean > that the Kafka process fails to start with the ConfigException, or when is > the ConfigException thrown? Would it be better to simply start behaving > like it is at least a new minimum regardless of topic setting, and then on > the fly fix the config instead? That would be much more convenient for most > Kafka users in my opinion. > > On Tue, Nov 19, 2024 at 12:55 PM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > > > KT1 - That is right. We will throw a ConfigException. That is why this > > change is considered backward incompatible. To be honest, given the > nature > > of suggested changes, I don't see any valid use case on why a user may > have > > a value which will be invalid after the new constraints. > > > > > > -- > > Divij Vaidya > > > > > > > > On Tue, Nov 19, 2024 at 2:21 AM Kirk True <k...@kirktrue.pro> wrote: > > > > > Hi Divij, > > > > > > Thanks for the KIP! > > > > > > My only question: > > > > > > KT1. In the case where we change the constraints so that a user's > > > previously valid configuration is now invalid, do we do anything other > > than > > > throw a ConfigException? > > > > > > Thanks, > > > Kirk > > > > > > On Mon, Nov 18, 2024, at 2:13 AM, Divij Vaidya wrote: > > > > Hey folks > > > > > > > > With 4.0, we have an opportunity to reset the default values and add > > > > constraints in the configurations based on our learnings since 3.0. > > > > > > > > Here's a KIP which modifies defaults for some properties and modifies > > the > > > > constraints for a few others. > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1030%3A+Change+constraints+and+default+values+for+various+configurations > > > > > > > > > > > > Looking forward for your feedback. > > > > > > > > (Previous discussion thread on this topic - > > > > https://lists.apache.org/thread/3dx9mdmsqf8pko9xdmhks80k96g650zp ) > > > > > > > > > >
