----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review51344 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsumerConfig.scala <https://reviews.apache.org/r/23655/#comment89559> Remove "symmetric" core/src/main/scala/kafka/consumer/PartitionAssignor.scala <https://reviews.apache.org/r/23655/#comment89556> I cannot understand a): what does "stream" of a topic-partition mean here? Should that be "each consumer instance have the same number of streams for each subscribed topic"? core/src/main/scala/kafka/consumer/PartitionAssignor.scala <https://reviews.apache.org/r/23655/#comment89557> It may be more helpful to log the partition results in the end than logging the starting of the partition at the beginning. core/src/main/scala/kafka/consumer/PartitionAssignor.scala <https://reviews.apache.org/r/23655/#comment89558> maybe " * "? - Guozhang Wang On Aug. 21, 2014, 1:10 a.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23655/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 1:10 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-687 > https://issues.apache.org/jira/browse/KAFKA-687 > > > Repository: kafka > > > Description > ------- > > v4 > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConfig.scala > 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 > core/src/main/scala/kafka/consumer/PartitionAssignor.scala PRE-CREATION > core/src/main/scala/kafka/consumer/TopicCount.scala > 8b0ae5785e08272d0ea12483beae597f2eac4343 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > acfd064bdba2b031f8869011da79649efd80946f > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala > 00df4621fd724826a1e79d849c762ac1c4f49868 > core/src/main/scala/kafka/utils/ZkUtils.scala > dcdc1ce2b02c996294e19cf480736106aaf29511 > core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/23655/diff/ > > > Testing > ------- > > * I did the unit tests (including the new one) as well as mirror maker system > test suite with roundrobin. While this is being reviewed I will run the > system tests with symmetric > > > Thanks, > > Joel Koshy > >
