Hi Dániel, Thanks for the review,
DU1,DU2: Based on suggestions, I have updated the config option to support ISO format. DU3: We will compute the timestamp on the client side and use that timestamp to fetch the offset from the server. This will be similar to the kafka-consumer-group cmd's --by-duration reset option. Thanks, On Mon, Nov 4, 2024 at 9:08 PM Dániel Urbán <urb.dani...@gmail.com> wrote: > > Hi Manikumar, > > Thanks for the KIP! I have a few questions: > 1. Why did you choose the "minus-" prefix for the new value format? Can't > we just drop the prefix? If we have to keep the prefix, I'd suggest > "last-N-Duration", as it somewhat "rhymes" with latest-earliest. > 2. Should minutes and seconds be also supported as durations? What about > fractions? I think the rejected ISO format has the advantage of flexibility > in this regard. > 3. More like a clarification than a question: "we will use > ListOffsetRequest to fetch the offset for the timestamp of the configured > duration" - this means that the offset will be reset based on the broker's > clock, and not the client's clock, correct? > > Thanks, > Daniel > > Manikumar <manikumar.re...@gmail.com> ezt írta (időpont: 2024. nov. 4., H, > 10:23): > > > Hi everyone, > > I would like to start a discussion on KIP-1106: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1106%3A+Add+duration+based+offset+reset+option+for+consumer+clients > > > > This KIP proposes to add an additional auto offset reset strategy for > > consumer clients. > > > > Regards, > > Manikumar > >
