Thanks for the KIP Bill. Very useful addition to be able to collect all
metrics broker side.
The KIP proposes to add a new thread-level metric for the thread state
similar to the existing client "state" metric. The KIP lacks the
corresponding definition though -- it only list the three new GAUGE
metrics, but not the new thread-level STRING metric. Can you add the
missing row to the table?
Note that the "Name" column is the MBean name.
Well, not really. Of course, all information is there, but the "Name" is
not the MBean name. The MBean is a concatenation of tags; cf
https://kafka.apache.org/documentation/#kafka_streams_client_monitoring
-- the MBean name is the last column, eg:
kafka.streams:type=stream-metrics,client-id=([-.\w]+)
-Matthias
On 10/31/24 3:43 PM, Bill Bejeck wrote:
Hi Apoorv,
Thanks for the comments. I've updated the table to include the information
you requested. Note that the "Name" column is the MBean name.
Regards,
Bill
On Tue, Oct 29, 2024 at 1:00 PM Apoorv Mittal <apoorvmitta...@gmail.com>
wrote:
Hi Bill,
Thanks for the KIP. I have a request, can we please define MBean and
telemetry names for the new metrics so it's easier to see where they will
be added (group, tags etc.)
Regards,
Apoorv Mittal
On Tue, Oct 29, 2024 at 5:15 AM Sophie Blee-Goldman <sop...@responsive.dev
wrote:
Hey Bill,
Thanks for the KIP! That all makes sense to me, just one minor note:
while
you mentioned the TRACE recording level in the Motivation section, it
seems
to be missing from the table in the Public Interfaces section. I assume
this will also be included, presumably with a value of 2?
Cheers,
Sophie
On Fri, Oct 25, 2024 at 12:20 PM Bill Bejeck <bbej...@apache.org> wrote:
Hi All,
I would like to start a discussion thread on KIP-1091:Improved Kafka
Streams operator metrics
Here's a link to the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics
I look forward to the discussion.
Thanks,
Bill
