Hi, Apoorv, Thanks for the KIP. A few comments.
1. TotalShareReleaseRequestsPerSec: This is a bit weird since there is no ShareReleaseRequest. 2. RequestTopicPartitionsFetchRatio and InFlightBatchMessageCount: It seems Histogram is more appropriate for them. 3. RequestTopicPartitionsFetchEmptyCount and AcquisitionLockTimeoutCount: The problem with using gauge is that if the value changes quickly, we may not be able to capture the occurrence of empty fetch or lock timeout. Meter captures those rare events better. Jun On Tue, Oct 29, 2024 at 8:48 AM Apoorv Mittal <apoorvmitta...@gmail.com> wrote: > Hi Everyone, > I would like to start a discussion on KIP-1103: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1103%3A+Additional+metrics+for+cooperative+consumption > > This KIP extends KIP-932 to provide additional metrics for > Queues/Cooperative consumption. > > Regards, > Apoorv Mittal >
