Hi Colin, I agree with you, this is not a blocker. We merged those to trunk and 3.8 already, but without your feedback. I'll try to address it today.
Best, ------------------ Josep Prat Open Source Engineering Director, Aiven josep.p...@aiven.io | +491715557497 | aiven.io Aiven Deutschland GmbH Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, Anna Richardson, Kenneth Chen Amtsgericht Charlottenburg, HRB 209739 B On Thu, Oct 10, 2024, 23:43 Colin McCabe <cmcc...@apache.org> wrote: > Thanks for the PR, Josep. > > I don't think it's critical to re-generate the RC since we can simply > update the docs on the website later as we've done in the past. If there is > a new RC after RC2, it will be there, though. > > Also it looks like this will be a good fix for 3.8.1 as well :) > > best, > Colin > > On Thu, Oct 10, 2024, at 09:51, Josep Prat wrote: > > Hi Colin, if you haven't started probably it makes sense to merge > > https://github.com/apache/kafka/pull/17447 as well. > > > > > > Best, > > ------------------ > > Josep Prat > > Open Source Engineering Director, Aiven > > josep.p...@aiven.io | +491715557497 | aiven.io > > Aiven Deutschland GmbH > > Alexanderufer 3-7, 10117 Berlin > > Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, > > Anna Richardson, Kenneth Chen > > Amtsgericht Charlottenburg, HRB 209739 B > > > > On Thu, Oct 10, 2024, 18:31 Colin McCabe <cmcc...@apache.org> wrote: > > > >> Hi all, > >> > >> I have merged KAFKA-17731 and KAFKA-17749 to 3.9. Also KAFKA-17751. > >> > >> We should be ready for the next RC now. > >> > >> Colin > >> > >> > >> On Thu, Oct 10, 2024, at 08:45, Mickael Maison wrote: > >> > Hi, > >> > > >> > Following up on https://issues.apache.org/jira/browse/KAFKA-17749. We > >> > merged the fix in trunk and 3.8. > >> > I opened a PR for 3.9: https://github.com/apache/kafka/pull/17457 > >> > > >> > Thanks, > >> > Mickael > >> > > >> > On Thu, Oct 10, 2024 at 3:14 PM Lianet M. <liane...@gmail.com> wrote: > >> >> > >> >> Hi Colin, > >> >> > >> >> Also, we discovered a bug affecting 3.9, that I would see as a > >> regression > >> >> given that it degrades the consumer#close. > >> >> > >> >> Fix has been merged to trunk with > >> https://github.com/apache/kafka/pull/17431 > >> >> so wonder if we should include it. > >> >> > >> >> Thanks, > >> >> > >> >> Lianet > >> >> > >> >> On Thu, Oct 10, 2024 at 9:09 AM Mickael Maison < > >> mickael.mai...@gmail.com> > >> >> wrote: > >> >> > >> >> > Hi Colin, > >> >> > > >> >> > In Kafka 3.8 we accidentally renamed a metric: > >> >> > https://issues.apache.org/jira/browse/KAFKA-17749 > >> >> > I wonder if we should include the fix to revert it to its original > >> >> > name in 3.9.0 (and 3.8.1) to limit the impact: > >> >> > https://github.com/apache/kafka/pull/17430 > >> >> > > >> >> > Thanks, > >> >> > Mickael > >> >> > > >> >> > On Wed, Oct 9, 2024 at 6:38 PM Josep Prat > <josep.p...@aiven.io.invalid > >> > > >> >> > wrote: > >> >> > > > >> >> > > Thanks Colin, > >> >> > > > >> >> > > I reviewed the PR you shared. > >> >> > > > >> >> > > Best, > >> >> > > > >> >> > > On Wed, Oct 9, 2024 at 6:26 PM Colin McCabe <cmcc...@apache.org> > >> wrote: > >> >> > > > >> >> > > > Hi Josep, > >> >> > > > > >> >> > > > I marked this as a blocker. We will take a look. I also found > some > >> >> > > > dependencies that need to be updated due to CVEs. See > >> >> > > > github.com/apache/kafka/pull/17436 > >> >> > > > > >> >> > > > best, > >> >> > > > Colin > >> >> > > > > >> >> > > > On Wed, Oct 9, 2024, at 05:52, Josep Prat wrote: > >> >> > > > > Hi Colin, > >> >> > > > > > >> >> > > > > I want to raise a bug we encountered while testing 3.9 RC0. > You > >> can > >> >> > find > >> >> > > > > the report here: > >> https://issues.apache.org/jira/browse/KAFKA-17751 > >> >> > > > > Its current severity is "high", but IMO it might even be a > >> blocker. > >> >> > What > >> >> > > > do > >> >> > > > > you think? > >> >> > > > > > >> >> > > > > Best, > >> >> > > > > > >> >> > > > > On Fri, Oct 4, 2024 at 5:18 PM José Armando García Sancio > >> >> > > > > <jsan...@confluent.io.invalid> wrote: > >> >> > > > > > >> >> > > > >> Thanks Colin. > >> >> > > > >> > >> >> > > > >> KAFKA-16927 has been merged to trunk and the 3.9 branch. > >> >> > > > >> > >> >> > > > >> -- > >> >> > > > >> -José > >> >> > > > >> > >> >> > > > > > >> >> > > > > > >> >> > > > > -- > >> >> > > > > [image: Aiven] > <https://www.google.com/maps/search/Aiven%5D++%0D?entry=gmail&source=g>< > https://www.aiven.io> > >> >> > > > > > >> >> > > > > *Josep Prat* > >> >> > > > > Open Source Engineering Director, *Aiven* > >> >> > > > > josep.p...@aiven.io | +491715557497 > >> >> > > > > aiven.io <https://www.aiven.io> | < > >> >> > > > https://www.facebook.com/aivencloud> > >> >> > > > > <https://www.linkedin.com/company/aiven/> < > >> >> > > > https://twitter.com/aiven_io> > >> >> > > > > *Aiven Deutschland GmbH* > >> >> > > > > Alexanderufer 3-7, 10117 Berlin > >> >> > > > > Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, > >> >> > > > > Anna Richardson, Kenneth Chen > >> >> > > > > Amtsgericht Charlottenburg, HRB 209739 B > >> >> > > > > >> >> > > > >> >> > > > >> >> > > -- > >> >> > > [image: Aiven] <https://www.aiven.io> > >> >> > > > >> >> > > *Josep Prat* > >> >> > > Open Source Engineering Director, *Aiven* > >> >> > > josep.p...@aiven.io | +491715557497 > >> >> > > aiven.io <https://www.aiven.io> | < > >> >> > https://www.facebook.com/aivencloud> > >> >> > > <https://www.linkedin.com/company/aiven/> < > >> >> > https://twitter.com/aiven_io> > >> >> > > *Aiven Deutschland GmbH* > >> >> > > Alexanderufer 3-7, 10117 Berlin > >> >> > > Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, > >> >> > > Anna Richardson, Kenneth Chen > >> >> > > Amtsgericht Charlottenburg, HRB 209739 B > >> >> > > >> >
