Hi Andrew, Thanks for reviewing and participating in the vote. I have corrected the issue as you pointed out.
Sincerely, TengYao Andrew Schofield <[email protected]> 於 2024年10月7日 週一 下午6:44寫道: > Thanks for the KIP. > > +1 (non-binding) > > I have one tiny nit that in the text but not the code snippet, you mention > methods called > CloseOption.withTimeoutFluent(Duration timeout) and > CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation > operation). > I expect you meant to remove "Fluent" in all cases so the text matches the > code snippet. > > Andrew > > ________________________________________ > From: TengYao Chi <[email protected]> > Sent: 07 October 2024 08:44 > To: [email protected] <[email protected]> > Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to > leave the group or not > > Hi Chia-Ping, > > Thanks for pointing that out. > I originally wrote the full version to show the equivalent semantic > example, but you're absolutely right—it can be simplified by omitting > `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since > it's the default value. > > This actually gave me an idea to include the shorter version for clarity in > the explanation. > I will update it accordingly. > > Sincerely, > TengYao > > Chia-Ping Tsai <[email protected]> 於 2024年10月7日 週一 下午1:13寫道: > > > +1 (binding) > > > > nit: in the "Migration Plan" > > > > ``` > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)) > > .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)); > > ``` > > > > The sample above can likely be simplified, right? > > > > ``` > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))); > > ``` > > > > Best, > > Chia-Ping > > > > TengYao Chi <[email protected]> 於 2024年10月7日 週一 上午10:23寫道: > > > > > Hi everyone, > > > > > > Based on our discussion > > > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m> > > > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I > > > believe this KIP is now ready for a vote. > > > > > > Sincerely, > > > TengYao > > > > > >
